linux-kernel - Re: [PATCH] dt-bindings: mmc: Add missing description for clk_in/out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFooWoUR4-=JWY16xw7qZKG5DGhQw8u6OQ4n42_VjkfgJQ@mail.gmail.com>
Date:   Tue, 25 Aug 2020 11:38:05 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Michal Simek <michal.simek@...inx.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Michal Simek <monstr@...str.eu>, git@...inx.com,
        Manish Narani <manish.narani@...inx.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Rob Herring <robh+dt@...nel.org>,
        Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@...el.com>,
        DTML <devicetree@...r.kernel.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: mmc: Add missing description for clk_in/out_sd1

On Mon, 24 Aug 2020 at 10:25, Michal Simek <michal.simek@...inx.com> wrote:
>
> The commit a8fdb80f4d47 ("arm64: zynqmp: Add ZynqMP SDHCI compatible
> string") added clock-output-names for both SDHCIs before DT binding yaml
> conversion. But only clk_in/out_sd0 clock names have been covered by
> DT binding which ends up with dt yaml checking warnings as:
> From schema: .../Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> ... mmc@...70000: clock-output-names:0: 'clk_out_sd0' was expected
> ... mmc@...70000: clock-output-names:1: 'clk_in_sd0' was expected
>
> Fixes: 16ecd8f33c6e ("dt-bindings: mmc: convert arasan sdhci bindings to yaml")
> Signed-off-by: Michal Simek <michal.simek@...inx.com>

Applied for fixes, thanks!

Kind regards
Uffe


> ---
>
>  .../devicetree/bindings/mmc/arasan,sdhci.yaml          | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> index 5887c917d480..58fe9d02a781 100644
> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> @@ -30,9 +30,13 @@ allOf:
>      then:
>        properties:
>          clock-output-names:
> -          items:
> -            - const: clk_out_sd0
> -            - const: clk_in_sd0
> +          oneOf:
> +            - items:
> +              - const: clk_out_sd0
> +              - const: clk_in_sd0
> +            - items:
> +              - const: clk_out_sd1
> +              - const: clk_in_sd1
>
>  properties:
>    compatible:
> --
> 2.28.0
>