lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Aug 2020 14:13:03 +0300 From: Mike Rapoport <rppt@...ux.ibm.com> To: Anders Roxell <anders.roxell@...aro.org>, Andrew Morton <akpm@...ux-foundation.org> Cc: Naresh Kamboju <naresh.kamboju@...aro.org>, Matthew Wilcox <willy@...radead.org>, linux-mm <linux-mm@...ck.org>, Linux-Next Mailing List <linux-next@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>, lkft-triage@...ts.linaro.org, LTP List <ltp@...ts.linux.it>, Arnd Bergmann <arnd@...db.de>, Russell King - ARM Linux <linux@...linux.org.uk>, Stephen Rothwell <sfr@...b.auug.org.au>, Catalin Marinas <catalin.marinas@....com>, Christoph Hellwig <hch@....de>, Andy Lutomirski <luto@...nel.org>, Peter Xu <peterx@...hat.com>, opendmb@...il.com, Linus Walleij <linus.walleij@...aro.org>, afzal.mohd.ma@...il.com, Will Deacon <will@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org> Subject: [PATCH] arm: __pmd_free_tlb(): call page table desctructor (Was: BUG: Bad page state in process true pfn:a8fed on arm) On Tue, Aug 25, 2020 at 10:53:22AM +0200, Anders Roxell wrote: > On Tue, 25 Aug 2020 at 10:32, Mike Rapoport <rppt@...ux.ibm.com> wrote: > > > > On Tue, Aug 25, 2020 at 01:03:53PM +0530, Naresh Kamboju wrote: > > > On Mon, 24 Aug 2020 at 16:36, Matthew Wilcox <willy@...radead.org> wrote: > > > > > > > > On Mon, Aug 24, 2020 at 03:14:55PM +0530, Naresh Kamboju wrote: > > > > > [ 67.545247] BUG: Bad page state in process true pfn:a8fed > > > > > [ 67.550767] page:9640c0ab refcount:0 mapcount:-1024 > > > > > > > > Somebody freed a page table without calling __ClearPageTable() on it. > > > > > > After running git bisect on this problem, > > > The first suspecting of this problem on arm architecture this patch. > > > 424efe723f7717430bec7c93b4d28bba73e31cf6 > > > ("mm: account PMD tables like PTE tables ") > > > > > > Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org> > > > Reported-by: Anders Roxell <anders.roxell@...aro.org> > > > > Can you please check if this fix helps? > > That fixed the problem. Since this is still in -mm tree, I've omitted commit sha and Fixes. Andrew, is it possible to add this as a fixup to for the original commit? >From db2efd7b89b1d943eb250e7e195c8cbaaa2e6ac9 Mon Sep 17 00:00:00 2001 From: Mike Rapoport <rppt@...ux.ibm.com> Date: Tue, 25 Aug 2020 13:57:12 +0300 Subject: [PATCH] arm: __pmd_free_tlb(): call page table desctructor As long as PMD tables are accounted as PTE tables ("mm: account PMD tables like PTE tables") they can be freed only after pgtable_pmd_page_dtor() is called. Add the missing call in ARM's version of __pmd_free_tlb for CONFIG_ARM_LPAE=y case. Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org> Reported-by: Anders Roxell <anders.roxell@...aro.org> Signed-off-by: Mike Rapoport <rppt@...ux.ibm.com> --- arch/arm/include/asm/tlb.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/include/asm/tlb.h b/arch/arm/include/asm/tlb.h index 9415222b49ad..b8cbe03ad260 100644 --- a/arch/arm/include/asm/tlb.h +++ b/arch/arm/include/asm/tlb.h @@ -59,6 +59,7 @@ __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmdp, unsigned long addr) #ifdef CONFIG_ARM_LPAE struct page *page = virt_to_page(pmdp); + pgtable_pmd_page_dtor(page); tlb_remove_table(tlb, page); #endif } -- 2.26.2
Powered by blists - more mailing lists