lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 25 Aug 2020 16:41:41 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Łukasz Stelmach <l.stelmach@...sung.com>
Cc:     Dan Williams <dan.j.williams@...el.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        b.zolnierkie@...sung.com
Subject: Re: [PATCH] dmaengine: pl330: fix instruction dump formatting

On 13-08-20, 22:41, Łukasz Stelmach wrote:
> Instruction dump uses two printk() in a row to print one instruction. Use
> KERN_CONT to prevent breaking the output in the middle.

Applied, thanks

> 
> Signed-off-by: Łukasz Stelmach <l.stelmach@...sung.com>
> ---
>  drivers/dma/pl330.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> index 88b884cbb7c1..e1af6a470453 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -254,7 +254,7 @@ enum pl330_byteswap {
>  static unsigned cmd_line;
>  #define PL330_DBGCMD_DUMP(off, x...)	do { \
>  						printk("%x:", cmd_line); \
> -						printk(x); \
> +						printk(KERN_CONT x); \
>  						cmd_line += off; \
>  					} while (0)
>  #define PL330_DBGMC_START(addr)		(cmd_line = addr)
> -- 
> 2.26.2

-- 
~Vinod

Powered by blists - more mailing lists