lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Aug 2020 20:57:13 +0800 From: "yukuai (C)" <yukuai3@...wei.com> To: Mark Brown <broonie@...nel.org> CC: <timur@...nel.org>, <nicoleotsuka@...il.com>, <Xiubo.Lee@...il.com>, <festevam@...il.com>, <shengjiu.wang@...il.com>, <lgirdwood@...il.com>, <perex@...ex.cz>, <tiwai@...e.com>, <shawnguo@...nel.org>, <s.hauer@...gutronix.de>, <kernel@...gutronix.de>, <linux-imx@....com>, <xobs@...agi.com>, <alsa-devel@...a-project.org>, <linuxppc-dev@...ts.ozlabs.org>, <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>, <yukuai@...wei.com>, <yi.zhang@...wei.com> Subject: Re: [PATCH 1/2] ASoC: fsl: imx-es8328: add missing kfree() call in imx_es8328_probe() On 2020/08/25 20:11, Mark Brown wrote: > On Tue, Aug 25, 2020 at 08:05:30PM +0800, Yu Kuai wrote: >> If memory allocation for 'data' or 'comp' succeed, imx_es8328_probe() >> doesn't have corresponding kfree() in exception handling. Thus add >> kfree() for this function implementation. > >> @@ -151,7 +151,7 @@ static int imx_es8328_probe(struct platform_device *pdev) >> comp = devm_kzalloc(dev, 3 * sizeof(*comp), GFP_KERNEL); >> if (!comp) { > > The allocation is being done using devm_ which means no explicit kfree() > is needed, the allocation will be automatically unwound when the device > is unbound. Hi, Thanks for pointing it out, I'll remove this patch. Best regards, Yu Kuai
Powered by blists - more mailing lists