linux-kernel - Re: [PATCH] memory: emif: Remove bogus debugfs error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10387fe0-579a-de71-44ad-ac585ff604d6@oracle.com>
Date:   Wed, 26 Aug 2020 09:52:37 -0700
From:   santosh.shilimkar@...cle.com
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Santosh Shilimkar <ssantosh@...nel.org>
Cc:     Krzysztof Kozlowski <krzk@...nel.org>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] memory: emif: Remove bogus debugfs error handling

On 8/26/20 4:37 AM, Dan Carpenter wrote:
> Callers are generally not supposed to check the return values from
> debugfs functions.  Debugfs functions never return NULL so this error
> handling will never trigger.  (Historically debugfs functions used to
> return a mix of NULL and error pointers but it was eventually deemed too
> complicated for something which wasn't intended to be used in normal
> situations).
> 
> Delete all the error handling.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
Looks good to me !!

Acked-by: Santosh Shilimkar <ssantosh@...nel.org>