linux-kernel - Re: [PATCH] memory: emif: Remove bogus debugfs error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200827193540.GA8837@kozik-lap>
Date:   Thu, 27 Aug 2020 21:35:40 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     santosh.shilimkar@...cle.com
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] memory: emif: Remove bogus debugfs error handling

On Wed, Aug 26, 2020 at 09:52:37AM -0700, santosh.shilimkar@...cle.com wrote:
> On 8/26/20 4:37 AM, Dan Carpenter wrote:
> > Callers are generally not supposed to check the return values from
> > debugfs functions.  Debugfs functions never return NULL so this error
> > handling will never trigger.  (Historically debugfs functions used to
> > return a mix of NULL and error pointers but it was eventually deemed too
> > complicated for something which wasn't intended to be used in normal
> > situations).
> > 
> > Delete all the error handling.
> > 
> > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> > ---
> Looks good to me !!
> 
> Acked-by: Santosh Shilimkar <ssantosh@...nel.org>

Thanks, applied.

Santosh,
Your email does not match one in ack.  I understand this is just a
mistake so I put the ack.  However the tool (b4-am) ignores such cases
so ack could be lost in the future.

Best regards,
Krzysztof