linux-kernel - Re: [PATCH v2 00/13] extcon: ptn5150: Improvements and fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 26 Aug 2020 16:56:01 -0500
From:   Suman Anna <s-anna@...com>
To:     Chanwoo Choi <cw00.choi@...sung.com>,
        <vadivel.muruganx.ramuthevar@...ux.intel.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Rob Herring <robh+dt@...nel.org>,
        Vijai Kumar K <vijaikumar.kanagarajan@...il.com>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>
CC:     "Menon, Nishanth" <nm@...com>
Subject: Re: [PATCH v2 00/13] extcon: ptn5150: Improvements and fixes

Hi Chanwoo,

On 8/24/20 6:28 AM, Chanwoo Choi wrote:
> Hi,
> 
> On 8/24/20 7:36 PM, Ramuthevar, Vadivel MuruganX wrote:
>> Hi,
>>
>>  Thank you for the patches and optimized the code as well.
>>  I have applied your patches and tested, it's working fine
>>  with few minor changes as per Intel's LGM board.
> 
> Thanks for the test.
> 
>>
>>  can I send the patches along with patches or we need to wait until
>>  your patch get merge?
>>
>>  Please suggest to me go further, Thanks!
> 
> I applied these patches. You better to send your patches
> based on extcon-next. Thanks.

I am not sure what happened, but the $id and $schema got morphed in the patch
on linux-next, 000ce2ad3c96 ("dt-bindings: extcon: ptn5150: Convert binding to
DT schema"), when compared to Krzysztof's original patch.

This is causing dtbs_check to fail in general on linux-next,
  UPD     include/config/kernel.release
  CHKDT   Documentation/devicetree/bindings/processed-schema-examples.json
Traceback (most recent call last):
  File
"/home/suman/.local/lib/python3.6/site-packages/jsonschema/validators.py", line
774, in resolve_from_url
    document = self.store[url]
  File "/home/suman/.local/lib/python3.6/site-packages/jsonschema/_utils.py",
line 22, in __getitem__
    return self.store[self.normalize(uri)]
KeyError:
'https://protect2.fireeye.com/url?k=59835ffc-05905d01-59822c67-0cc47a336902-306bd2691e458c36&q=1&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File
"/home/suman/.local/lib/python3.6/site-packages/jsonschema/validators.py", line
777, in resolve_from_url
    document = self.resolve_remote(url)
  File
"/home/suman/.local/lib/python3.6/site-packages/jsonschema/validators.py", line
860, in resolve_remote
    result = requests.get(uri).json()
  File "/usr/lib/python3/dist-packages/requests/models.py", line 892, in json
    return complexjson.loads(self.text, **kwargs)
  File "/usr/lib/python3/dist-packages/simplejson/__init__.py", line 518, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3/dist-packages/simplejson/decoder.py", line 370, in decode
    obj, end = self.raw_decode(s)
  File "/usr/lib/python3/dist-packages/simplejson/decoder.py", line 400, in
raw_decode
    return self.scan_once(s, idx=_w(s, idx).end())
simplejson.errors.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/suman/.local/bin/dt-doc-validate", line 67, in <module>
    ret = check_doc(f)
  File "/home/suman/.local/bin/dt-doc-validate", line 33, in check_doc
    for error in sorted(dtschema.DTValidator.iter_schema_errors(testtree),
key=lambda e: e.linecol):
  File "/home/suman/.local/lib/python3.6/site-packages/dtschema/lib.py", line
663, in iter_schema_errors
    meta_schema = cls.resolver.resolve_from_url(schema['$schema'])
  File
"/home/suman/.local/lib/python3.6/site-packages/jsonschema/validators.py", line
779, in resolve_from_url
    raise exceptions.RefResolutionError(exc)
jsonschema.exceptions.RefResolutionError: Expecting value: line 1 column 1 (char 0)
Documentation/devicetree/bindings/Makefile:52: recipe for target
'Documentation/devicetree/bindings/processed-schema-examples.json' failed
make[1]: *** [Documentation/devicetree/bindings/processed-schema-examples.json]
Error 123
Makefile:1366: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2

regards
Suman

> 
>>
>> On 17/8/2020 2:59 pm, Krzysztof Kozlowski wrote:
>>> Hi,
>>>
>>> Changes since v1:
>>> 1. Mutex unlock fix in patch 8/13.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>
>>
> 
>