linux-kernel - Re: [PATCH v1 0/9] extcon: extcon-ptn5150: Add the USB external connector support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 26 Aug 2020 12:18:04 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     "Ramuthevar, Vadivel MuruganX" 
        <vadivel.muruganx.ramuthevar@...ux.intel.com>
Cc:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>, thomas.langer@...el.com,
        cheol.yong.kim@...el.com, qi-ming.wu@...el.com, yin1.li@...el.com,
        krzk@...nel.org
Subject: Re: [PATCH v1 0/9] extcon: extcon-ptn5150: Add the USB external
 connector support

On Wed, Aug 26, 2020 at 10:51:37AM +0800, Ramuthevar, Vadivel MuruganX wrote:
> On 25/8/2020 4:19 pm, Heikki Krogerus wrote:
> > On Wed, Aug 19, 2020 at 04:45:38PM +0800, Ramuthevar, Vadivel MuruganX wrote:
> > > On 19/8/2020 3:55 pm, Andy Shevchenko wrote:
> > > > On Wed, Aug 19, 2020 at 8:38 AM Ramuthevar, Vadivel MuruganX
> > > > <vadivel.muruganx.ramuthevar@...ux.intel.com> wrote:
> > > > > On 18/8/2020 4:40 pm, Andy Shevchenko wrote:
> > > > > > On Tue, Aug 18, 2020 at 02:57:18PM +0800, Ramuthevar,Vadivel MuruganX wrote:
> > > > > > > USB external connector chip PTN5150 used on the Intel LGM SoC
> > > > > > > boards to detect the USB type and connection.
> > > > > > Internally I meant you can send cleanups, but couple of patches here are the
> > > > > > features and were still under discussion... But here we are.
> > > > > 
> > > > > you mean asking us to implement the Heikki suggested as below..
> > > > > 
> > > > > Heikki Krogerus: register the port and the partner attached to it with
> > > > > the USB Type-C connector class in the driver. Is my understaanding
> > > > > right? if not, please explain it. Thanks!
> > > > 
> > > > When you mention somebody, don't forget to Cc them (now done by me).
> > > Sure, Thank you
> > 
> > So the patches 1-5 are fine. The rest needs to be rewritten.
> Already Krzysztof submitted all the patches and got approved, so we started
> sending only one patch which support to Intel LGM SoC based boards, Thanks!

I'm not sure what you meant by above.

Krzysztof suggested you to squash all first patches into 1 (or two) and he
approves it. What you have to do is follow his advise and send v2 where it will
be one (or two) patch with his tag attached.

Krzysztof, is it correct what I'm saying?

-- 
With Best Regards,
Andy Shevchenko