linux-kernel - Re: [PATCH v8 1/2] Add a "nosymfollow" mount option.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200827154139.vwuflrlvj257krnw@yavin.dot.cyphar.com>
Date:   Fri, 28 Aug 2020 01:41:39 +1000
From:   Aleksa Sarai <cyphar@...har.com>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     Ross Zwisler <zwisler@...gle.com>, linux-kernel@...r.kernel.org,
        Mattias Nissler <mnissler@...omium.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Benjamin Gordon <bmgordon@...gle.com>,
        David Howells <dhowells@...hat.com>,
        Dmitry Torokhov <dtor@...gle.com>,
        Jesse Barnes <jsbarnes@...gle.com>,
        linux-fsdevel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        Matthew Wilcox <willy@...radead.org>,
        Micah Morton <mortonm@...gle.com>,
        Raul Rangel <rrangel@...gle.com>, Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH v8 1/2] Add a "nosymfollow" mount option.

On 2020-08-27, Al Viro <viro@...iv.linux.org.uk> wrote:
> On Wed, Aug 26, 2020 at 02:48:19PM -0600, Ross Zwisler wrote:
> 
> > Al, now that the changes to fs/namei.c have landed and we're past the merge
> > window for v5.9, what are your thoughts on this patch and the associated test?
> 
> Humm...  should that be nd->path.mnt->mnt_flags or link->mnt->mnt_flags?
> Usually it's the same thing, but they might differ.  IOW, is that about the
> directory we'd found it in, or is it about the link itself?

Now that you mention it, I think link->mnt->mnt_flags makes more sense.
The restriction should apply in the context of whatever filesystem
contains the symlink, and that would matches FreeBSD's semantics (at
least as far as I can tell from a quick look at sys/kern/vfs_lookup.c).

-- 
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)