linux-kernel - Re: [PATCH v8 1/2] Add a "nosymfollow" mount option.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200827164857.GA414369@google.com>
Date:   Thu, 27 Aug 2020 10:48:57 -0600
From:   Ross Zwisler <zwisler@...gle.com>
To:     Aleksa Sarai <cyphar@...har.com>
Cc:     Al Viro <viro@...iv.linux.org.uk>, linux-kernel@...r.kernel.org,
        Mattias Nissler <mnissler@...omium.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Benjamin Gordon <bmgordon@...gle.com>,
        David Howells <dhowells@...hat.com>,
        Dmitry Torokhov <dtor@...gle.com>,
        Jesse Barnes <jsbarnes@...gle.com>,
        linux-fsdevel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        Matthew Wilcox <willy@...radead.org>,
        Micah Morton <mortonm@...gle.com>,
        Raul Rangel <rrangel@...gle.com>, Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH v8 1/2] Add a "nosymfollow" mount option.

On Fri, Aug 28, 2020 at 01:41:39AM +1000, Aleksa Sarai wrote:
> On 2020-08-27, Al Viro <viro@...iv.linux.org.uk> wrote:
> > On Wed, Aug 26, 2020 at 02:48:19PM -0600, Ross Zwisler wrote:
> > 
> > > Al, now that the changes to fs/namei.c have landed and we're past the merge
> > > window for v5.9, what are your thoughts on this patch and the associated test?
> > 
> > Humm...  should that be nd->path.mnt->mnt_flags or link->mnt->mnt_flags?
> > Usually it's the same thing, but they might differ.  IOW, is that about the
> > directory we'd found it in, or is it about the link itself?
> 
> Now that you mention it, I think link->mnt->mnt_flags makes more sense.
> The restriction should apply in the context of whatever filesystem
> contains the symlink, and that would matches FreeBSD's semantics (at
> least as far as I can tell from a quick look at sys/kern/vfs_lookup.c).

Yep, changing this to link->mnt->mnt_flags makes sense to me, as you're right
that we care about the link itself and not the link's parent directory.  Thank
you for the review, and I'll send out v9 momentarily.