linux-kernel - Re: [PATCH v2 5/5] fpga manager: xilinx-spi: provide better diagnostics on programming failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa201535-a5f6-04b1-1444-35b68ed47281@redhat.com>
Date:   Thu, 27 Aug 2020 12:09:03 -0700
From:   Tom Rix <trix@...hat.com>
To:     Luca Ceresoli <luca@...aceresoli.net>, linux-fpga@...r.kernel.org
Cc:     Moritz Fischer <mdf@...nel.org>,
        Michal Simek <michal.simek@...inx.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Anatolij Gustschin <agust@...x.de>
Subject: Re: [PATCH v2 5/5] fpga manager: xilinx-spi: provide better
 diagnostics on programming failure


On 8/27/20 7:32 AM, Luca Ceresoli wrote:
> When the DONE pin does not go high after programming to confirm programming
> success, the INIT_B pin provides some info on the reason. Use it if
> available to provide a more explanatory error message.
>
> Signed-off-by: Luca Ceresoli <luca@...aceresoli.net>
>
> ---
>
> Changes in v2:
>  - also check for gpiod_get_value() errors (Tom Rix)

This looks fine.

Reviewed-by: Tom Rix <trix@...hat.com>