linux-kernel - Re: [PATCH] linux/kernel.h: add container

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202008261929.A50D0DB3E8@keescook>
Date:   Wed, 26 Aug 2020 19:31:40 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Allen Pais <allen.lkml@...il.com>
Cc:     torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
        tglx@...utronix.de, linux-kernel@...r.kernel.org,
        "James E . J . Bottomley" <James.Bottomley@...senPartnership.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH] linux/kernel.h: add container_from()

On Thu, Aug 27, 2020 at 07:06:36AM +0530, Allen Pais wrote:
> Introduce container_from() as a generic helper instead of
> sub-systems defining a private from_* API
> (Eg: from_tasklets recently introduced in
> 12cc923f1ccc: Tasklet: Introduce new initialization API)
> 
> The helper is similar to container_of() in argument order
> with the difference of naming the containing structure instead
> of having to specify its type.
> 
> Suggested-by: James E.J. Bottomley <James.Bottomley@...senPartnership.com>
> Suggested-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Suggested-by: Jens Axboe <axboe@...nel.dk>
> Signed-off-by: Allen Pais <allen.lkml@...il.com>

Acked-by: Kees Cook <keescook@...omium.org>

Who can carry this so it can get used by multiple trees? Should I keep a
git branch folks should merge when taking Allen's conversion patches?

(In the future we can do a treewide replacement of the
subsystem-specific from*() macros into container_from())

Thanks!

-- 
Kees Cook