linux-kernel - Re: [PATCH v5 0/7] Fix timeout clock used by hardware data timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 26 Aug 2020 19:58:22 -0700
From:   Sowjanya Komatineni <skomatineni@...dia.com>
To:     <adrian.hunter@...el.com>, <ulf.hansson@...aro.org>,
        <thierry.reding@...il.com>, <jonathanh@...dia.com>,
        <robh+dt@...nel.org>
CC:     <linux-tegra@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-mmc@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <stable@...r.kernel.org>
Subject: Re: [PATCH v5 0/7] Fix timeout clock used by hardware data timeout

Sorry please ignore this series.

Wrong patches from my system went out.

Will send as v6.

Thanks

Sowjanya

On 8/26/20 1:05 PM, Sowjanya Komatineni wrote:
> Tegra210/Tegra186/Tegra194 has incorrectly enabled
> SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK from the beginning of their support.
>
> Tegra210 and later SDMMC hardware default uses sdmmc_legacy_tm (TMCLK)
> all the time for hardware data timeout instead of SDCLK and this TMCLK
> need to be kept enabled by Tegra sdmmc driver.
>
> This series includes patches to fix this for Tegra210/Tegra186/Tegra194.
>
> These patches need to be manually backported for 4.9, 4.14 and 4.19.
>
> Will send patches to backport separately once these patches are ack'd.
>
> Delta between patch versions:
> [v5]:	Include below changes based on v4 feedback
> 	- updated dt-binding doc to be more clear
> 	- updated Tegra sdhci driver to retrieve sdhci and tmclk clocks
> 	  based on no. of clocks in sdhci device node as old device trees
> 	  do not use sdhci clock name and this allows proper clock retrival
> 	  irrespective of sdhci and tmclk clocks order in device tree.	
> 	- Added separate quirk for identifying SoC's supporting separate
> 	  timeout clock to be more clear.
>
> [v4]:	Include additional dt-binding patch
>
> [v3]:	Same as v2 with fixes tag
>
> [v2]:	Includes minor fix
> 	- Patch-0006: parentheses around operand of '!'
>
> Sowjanya Komatineni (7):
>    sdhci: tegra: Remove SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK for Tegra210
>    sdhci: tegra: Remove SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK for Tegra186
>    dt-bindings: mmc: tegra: Add tmclk for Tegra210 and later
>    arm64: tegra: Add missing timeout clock to Tegra210 SDMMC
>    arm64: tegra: Add missing timeout clock to Tegra186 SDMMC nodes
>    arm64: tegra: Add missing timeout clock to Tegra194 SDMMC nodes
>    sdhci: tegra: Add missing TMCLK for data timeout
>
>   .../bindings/mmc/nvidia,tegra20-sdhci.txt          | 32 +++++++-
>   arch/arm64/boot/dts/nvidia/tegra186.dtsi           | 20 +++--
>   arch/arm64/boot/dts/nvidia/tegra194.dtsi           | 15 ++--
>   arch/arm64/boot/dts/nvidia/tegra210.dtsi           | 20 +++--
>   drivers/mmc/host/sdhci-tegra.c                     | 91 +++++++++++++++++++---
>   5 files changed, 143 insertions(+), 35 deletions(-)
>