linux-kernel - Re: [PATCH] crypto: cavium/nitrox: add an error message to explain the failure of pci_request_mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 29 Aug 2020 22:04:09 +1000
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     George Acosta <acostag.ubuntu@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Phani Kiran Hemadri <phemadri@...vell.com>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: cavium/nitrox: add an error message to explain
 the failure of pci_request_mem_regions

On Fri, Aug 28, 2020 at 08:53:36PM -0500, George Acosta wrote:
> Hi Herbert,
> I just noticed a small potential issue about the calling sequence of
> pci_disable_device and dev_err.
> Do you think it will be better to call dev_err before we call
> pci_disable_device(pdev) , or the order here does not matter?

I don't think it matters.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt