lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 28 Aug 2020 20:53:36 -0500 From: George Acosta <acostag.ubuntu@...il.com> To: Herbert Xu <herbert@...dor.apana.org.au> Cc: "David S. Miller" <davem@...emloft.net>, Christophe JAILLET <christophe.jaillet@...adoo.fr>, "Gustavo A. R. Silva" <gustavo@...eddedor.com>, Phani Kiran Hemadri <phemadri@...vell.com>, linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] crypto: cavium/nitrox: add an error message to explain the failure of pci_request_mem_regions Hi Herbert, I just noticed a small potential issue about the calling sequence of pci_disable_device and dev_err. Do you think it will be better to call dev_err before we call pci_disable_device(pdev) , or the order here does not matter? On Fri, Aug 28, 2020 at 2:19 AM Herbert Xu <herbert@...dor.apana.org.au> wrote: > > On Thu, Aug 20, 2020 at 10:12:08PM -0500, George Acosta wrote: > > Provide an error message for users when pci_request_mem_regions failed. > > > > Signed-off-by: George Acosta <acostag.ubuntu@...il.com> > > --- > > drivers/crypto/cavium/nitrox/nitrox_main.c | 1 + > > 1 file changed, 1 insertion(+) > > Patch applied. Thanks. > -- > Email: Herbert Xu <herbert@...dor.apana.org.au> > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt Thanks, George
Powered by blists - more mailing lists