lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 29 Aug 2020 09:12:22 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     Shuo A Liu <shuo.a.liu@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, "H . Peter Anvin" <hpa@...or.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        Yu Wang <yu1.wang@...el.com>,
        Reinette Chatre <reinette.chatre@...el.com>, x86@...nel.org,
        Zhi Wang <zhi.a.wang@...el.com>,
        Zhenyu Wang <zhenyuw@...ux.intel.com>
Subject: Re: [PATCH 05/17] virt: acrn: Introduce ACRN HSM basic driver

On 8/29/20 3:46 AM, Shuo A Liu wrote:
> On Fri 28.Aug'20 at 12:25:59 +0200, Greg Kroah-Hartman wrote:
>> On Tue, Aug 25, 2020 at 10:45:05AM +0800, shuo.a.liu@...el.com wrote:
>>> +static long acrn_dev_ioctl(struct file *filp, unsigned int cmd,
>>> +               unsigned long ioctl_param)
>>> +{
>>> +    if (cmd == ACRN_IOCTL_GET_API_VERSION) {
>>> +        if (copy_to_user((void __user *)ioctl_param,
>>> +                 &api_version, sizeof(api_version)))
>>> +            return -EFAULT;
>>
>> Why are you versioning your api?  Shouldn't that not be a thing and you
>> either support an ioctl or you do not?
> 
> The API version here is more for the hypercalls.
> The hypercalls might evolve later

They might evolve, but the old ones must always keep working.  Right?

> and the version indicates which set of interfaces (include the
> paramters' format) should be used by user space tools. Currently,
> it's used rarely.
Why do you need this when the core kernel doesn't?  We add syscalls,
ioctl()s and prctl()s all the time, but nothing is versioned.

This sounds like something you need to remove from the series.

Powered by blists - more mailing lists