linux-kernel - Re: [PATCH 1/1] iio: gyro: adxrs290: Insert missing mutex initialization call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 29 Aug 2020 17:25:54 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Nishant Malpani <nish.malpani25@...il.com>
Cc:     dragos.bogdan@...log.com, darius.berghe@...log.com,
        linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org
Subject: Re: [PATCH 1/1] iio: gyro: adxrs290: Insert missing mutex
 initialization call

On Tue, 25 Aug 2020 18:15:52 +0530
Nishant Malpani <nish.malpani25@...il.com> wrote:

> Insert a missing mutex_init() call during the probe that initializes
> the driver's local lock to unlocked state.
> 
> Fixes: 2c8920fff145 ("iio: gyro: Add driver support for ADXRS290")
> Signed-off-by: Nishant Malpani <nish.malpani25@...il.com>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it

Thanks,

Jonathan

> ---
>  drivers/iio/gyro/adxrs290.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/gyro/adxrs290.c b/drivers/iio/gyro/adxrs290.c
> index 38bab4e3eee9..ff989536d2fb 100644
> --- a/drivers/iio/gyro/adxrs290.c
> +++ b/drivers/iio/gyro/adxrs290.c
> @@ -385,6 +385,8 @@ static int adxrs290_probe(struct spi_device *spi)
>  	indio_dev->num_channels = ARRAY_SIZE(adxrs290_channels);
>  	indio_dev->info = &adxrs290_info;
>  
> +	mutex_init(&st->lock);
> +
>  	val = spi_w8r8(spi, ADXRS290_READ_REG(ADXRS290_REG_ADI_ID));
>  	if (val != ADXRS290_ADI_ID) {
>  		dev_err(&spi->dev, "Wrong ADI ID 0x%02x\n", val);