lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 29 Aug 2020 23:23:39 +0300
From:   Denis Efremov <>
To:     Joe Perches <>, LKML <>,
        Greg Kroah-Hartman <>,
        "Rafael J. Wysocki" <>,
        Kees Cook <>,
        "Gustavo A . R . Silva" <>,
        Julia Lawall <>,
        Alex Dewar <>
Cc:     York Sun <>, Borislav Petkov <>,
        Mauro Carvalho Chehab <>,
        Tony Luck <>,
        James Morse <>,
        Robert Richter <>,
        Michal Simek <>,
        Boris Brezillon <>,
        Maxim Levitsky <>,
        Alex Dubov <>,
        Ulf Hansson <>,
        Tomas Winkler <>,
        Arnd Bergmann <>,
        Madalin Bucur <>,
        "David S. Miller" <>,
        Jakub Kicinski <>,
        Douglas Miller <>,
        Stanislav Yakovlev <>,
        Kalle Valo <>,
        Darren Hart <>,
        Andy Shevchenko <>,
        Kai Mäkisara <>,
        "James E.J. Bottomley" <>,
        "Martin K. Petersen" <>,
        Mark Brown <>,
        Oliver Neukum <>,
        Pete Zaitcev <>,,,,,,,,,,
Subject: Re: sysfs output without newlines


On 8/29/20 9:23 PM, Joe Perches wrote:
> While doing an investigation for a possible treewide conversion of
> sysfs output using sprintf/snprintf/scnprintf, I discovered
> several instances of sysfs output without terminating newlines.
> It seems likely all of these should have newline terminations
> or have the \n\r termination changed to a single newline.

I think that it could break badly written scripts in rare cases.

> Anyone have any objection to patches adding newlines to these
> in their original forms using sprintf/snprintf/scnprintf?

I'm not sure about existing cases, but I think it's a good warning for new patches. It should be 
possible to check sysfs_emit() calls.


Powered by blists - more mailing lists