linux-kernel - Re: [PATCH 09/33] ARM: dts: exynos: Add and enable 32 kHz modem clock in Origen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 31 Aug 2020 11:16:09 +0200
From:   Marek Szyprowski <m.szyprowski@...sung.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Kukjin Kim <kgene@...nel.org>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Denis GNUtoo Carikli <GNUtoo@...erdimension.org>,
        Simon Shields <simon@...eageos.org>
Cc:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Sylwester Nawrocki <snawrocki@...nel.org>
Subject: Re: [PATCH 09/33] ARM: dts: exynos: Add and enable 32 kHz modem
 clock in Origen

Hi Krzysztof,

On 30.08.2020 15:51, Krzysztof Kozlowski wrote:
> The PMIC has a 32768 Hz clock used by the modem which is implemented by
> driver as a regulator.  Add and enable it to be sure modem get's its
> signal.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>

Origen board doesn't have any modem/cp, so I see no point in enabling 
this clock.

> ---
>   arch/arm/boot/dts/exynos4210-origen.dts | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts
> index 747221bbb856..fcf45619a3e4 100644
> --- a/arch/arm/boot/dts/exynos4210-origen.dts
> +++ b/arch/arm/boot/dts/exynos4210-origen.dts
> @@ -298,6 +298,11 @@
>   				regulator-name = "EN32KHZ_AP";
>   				regulator-always-on;
>   			};
> +
> +			EN32KHZ_CP {
> +				regulator-name = "EN32KHZ_CP";
> +				regulator-always-on;
> +			};
>   		};
>   	};
>   };

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland