linux-kernel - Re: [PATCH] fs/affs: Fix basic permission bits to actually work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200831093848.GS28318@twin.jikos.cz>
Date:   Mon, 31 Aug 2020 11:38:48 +0200
From:   David Sterba <dsterba@...e.cz>
To:     Max Staudt <max@...as.org>
Cc:     David Sterba <dsterba@...e.com>, linux-fsdevel@...r.kernel.org,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        linux-m68k@...r.kernel.org, glaubitz@...sik.fu-berlin.de,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] fs/affs: Fix basic permission bits to actually work

On Thu, Aug 27, 2020 at 05:49:00PM +0200, Max Staudt wrote:
> The basic permission bits (protection bits in AmigaOS) have been broken
> in Linux' affs - it would only set bits, but never delete them.
> Also, contrary to the documentation, the Archived bit was not handled.
> 
> Let's fix this for good, and set the bits such that Linux and classic
> AmigaOS can coexist in the most peaceful manner.
> 
> Also, update the documentation to represent the current state of things.
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Cc: stable@...r.kernel.org
> Signed-off-by: Max Staudt <max@...as.org>

Thanks, patch looks good to me, I'll send a pull request to Linus this
week.