linux-kernel - Re: [PATCH 4/4] arm64: dts: rockchip: enable rk3328-rock64 usb3 nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 31 Aug 2020 13:49:41 +0200
From:   Johan Jonker <jbx6244@...il.com>
To:     lindsey.stanpoor@...il.com, linux-usb@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org
Cc:     gregkh@...uxfoundation.org, cnemo@...anota.com, robh+dt@...nel.org,
        heiko@...ech.de, balbi@...nel.org
Subject: Re: [PATCH 4/4] arm64: dts: rockchip: enable rk3328-rock64 usb3 nodes

Hi Cameron,

Increase the version number for each new patch serie.

git format-patch -v4 -4 HEAD

In a previous comment I gave a sort example.
However, this patch serie is about usb3, so only touch the things
related to usb3 and leave the &uart2 node (legacy ;) ) untouched.

Improve the way in which your patches are send.

Your previous serie was incomplete.
Submit all patches with the same news server (Gmail for example) that
can handle plain text, because else you get 2 different Message-Ids:
<20200826171230.17041-2-lindsey.stanpoor@...il.com>
<20200826170623.15469-2-travelvia@...mail.cc>

git send-email --suppress-cc all --annotate --to <..> --cc <..> <patch1
patch2>

Not sure how robh filters patches, but your serie 'must' show up in the
link below or else wait for an eternity to get a ack-by.

https://patchwork.ozlabs.org/project/devicetree-bindings/list/


On 8/26/20 7:12 PM, lindsey.stanpoor@...il.com wrote:
> From: Cameron Nemo <cnemo@...anota.com>
> 
> Enable USB3 nodes for the rk3328-based PINE Rock64 board.
> 
> Signed-off-by: Heiko Stuebner <heiko@...ech.de>
> Signed-off-by: Cameron Nemo <cnemo@...anota.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> index 86cfb5c50a94..82c27eab6a52 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> @@ -363,10 +363,6 @@ &tsadc {
>  	status = "okay";
>  };
>  

> -&uart2 {
> -	status = "okay";
> -};
> -

>  &u2phy {
>  	status = "okay";
>  
> @@ -379,11 +375,24 @@ u2phy_otg: otg-port {
>  	};
>  };
>  

> +&uart2 {
> +	status = "okay";
> +};
> +

Don't touch/change.

>  &usb20_otg {
>  	dr_mode = "host";
>  	status = "okay";
>  };
>  
> +&usbdrd3 {
> +	status = "okay";
> +};
> +
> +&usbdrd_dwc3 {
> +	dr_mode = "host";
> +	status = "okay";
> +};
> +
>  &usb_host0_ehci {
>  	status = "okay";
>  };
>