linux-kernel - Re: [PATCH v2 3/3] crypto: sun4i-ss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200831115024.GA14248@Red>
Date:   Mon, 31 Aug 2020 13:50:24 +0200
From:   Corentin Labbe <clabbe.montjoie@...il.com>
To:     Martin Cerveny <m.cerveny@...puter.org>
Cc:     Chen-Yu Tsai <wens@...e.org>,
        "David S. Miller" <davem@...emloft.net>,
        devicetree@...r.kernel.org,
        Herbert Xu <herbert@...dor.apana.org.au>,
        linux-arm-kernel@...ts.infradead.org, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, Maxime Ripard <mripard@...nel.org>,
        Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH v2 3/3] crypto: sun4i-ss - add the V3s variant of SS

On Mon, Aug 31, 2020 at 09:31:01AM +0200, Martin Cerveny wrote:
> Like A33 "sun4i-ss" has a difference, it give SHA1 digest
> directly in BE. So add new compatible.
> 
> Tested-by: Martin Cerveny <m.cerveny@...puter.org>
> Signed-off-by: Martin Cerveny <m.cerveny@...puter.org>
> ---
>  drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 

Your commit message is wrong, "sun4i-ss" has no difference, but V3S yes.
Your other patch has the same problem.

Otherwise you could add:
Acked-by: Corentin Labbe <clabbe.montjoie@...il.com>

Regards