lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 1 Sep 2020 10:46:16 +0200 From: Sedat Dilek <sedat.dilek@...il.com> To: Willy Tarreau <w@....eu> Cc: Yann Ylavic <ylavic.dev@...il.com>, linux-kernel@...r.kernel.org, Linux Kernel Network Developers <netdev@...r.kernel.org>, George Spelvin <lkml@....org>, Amit Klein <aksecurity@...il.com>, Eric Dumazet <edumazet@...gle.com>, "Jason A. Donenfeld" <Jason@...c4.com>, Andy Lutomirski <luto@...nel.org>, Kees Cook <keescook@...omium.org>, Thomas Gleixner <tglx@...utronix.de>, Peter Zijlstra <peterz@...radead.org>, Linus Torvalds <torvalds@...ux-foundation.org>, tytso@....edu, Florian Westphal <fw@...len.de>, Marc Plumb <lkml.mplumb@...il.com> Subject: Re: [PATCH 1/2] random32: make prandom_u32() output unpredictable On Tue, Sep 1, 2020 at 10:39 AM Willy Tarreau <w@....eu> wrote: > > On Tue, Sep 01, 2020 at 10:33:40AM +0200, Yann Ylavic wrote: > > On Tue, Sep 1, 2020 at 8:45 AM Willy Tarreau <w@....eu> wrote: > > > > > > +/* > > > + * Generate some initially weak seeding values to allow > > > + * the prandom_u32() engine to be started. > > > + */ > > > +static int __init prandom_init_early(void) > > > +{ > > > + int i; > > > + unsigned long v0, v1, v2, v3; > > > + > > > + if (!arch_get_random_long(&v0)) > > > + v0 = jiffies; > > > + if (!arch_get_random_long(&v1)) > > > + v0 = random_get_entropy(); > > > > Shouldn't the above be: > > v1 = random_get_entropy(); > > ? > > Very good catch, many thanks Yann! Now fixed in my local tree. > Thanks for offering a new patchset, Willy. Will you push the updated patchset to your prandom Git - for easy fetching? Thanks. - Sedat - [1] https://git.kernel.org/pub/scm/linux/kernel/git/wtarreau/prandom.git/
Powered by blists - more mailing lists