linux-kernel - Re: [PATCH] i2c: algo-pca: Reapply i2c bus settings after reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200901084619.GA897@ninjato>
Date:   Tue, 1 Sep 2020 10:46:19 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Evan Nimmo <evan.nimmo@...iedtelesis.co.nz>, jdelvare@...e.de,
        jarkko.nikula@...ux.intel.com, chris.packham@...iedtelesis.co.nz,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: algo-pca: Reapply i2c bus settings after reset


> > +/**
> > + * struct i2c_bus_settings - The configured i2c bus settings
> > + * @mode: Configured i2c bus mode (PCA9665)
> > + * @tlow: Configured SCL LOW period (PCA9665)
> > + * @thi: Configured SCL HIGH period (PCA9665)
> > + * @clock_freq: The configured clock frequency (PCA9564)
> > + */
> > +struct i2c_bus_settings {
> > +	int mode;
> > +	int tlow;
> > +	int thi;
> > +	int clock_freq;
> > +};
> 
> This is a good candidate to have it in generic header for sake of the
> unification. Possible users:
> 
> struct tegra_i2c_hw_feature
> struct cci_data::struct hw_params

Could be evaluated, but outside the scope of this patch, I think. This
is a bugfix, so a self-contained patch makes backporting a lot easier.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)