linux-kernel - Re: [PATCH] i2c: algo-pca: Reapply i2c bus settings after reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdGkHqr_bJ5f2hf0yfk5rTAdpNkBUzcM=JGHKgnhyo-=Q@mail.gmail.com>
Date:   Tue, 1 Sep 2020 11:50:48 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Wolfram Sang <wsa@...nel.org>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Evan Nimmo <evan.nimmo@...iedtelesis.co.nz>,
        Jean Delvare <jdelvare@...e.de>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Chris Packham <chris.packham@...iedtelesis.co.nz>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i2c: algo-pca: Reapply i2c bus settings after reset

On Tue, Sep 1, 2020 at 11:48 AM Wolfram Sang <wsa@...nel.org> wrote:
> > > +/**
> > > + * struct i2c_bus_settings - The configured i2c bus settings
> > > + * @mode: Configured i2c bus mode (PCA9665)
> > > + * @tlow: Configured SCL LOW period (PCA9665)
> > > + * @thi: Configured SCL HIGH period (PCA9665)
> > > + * @clock_freq: The configured clock frequency (PCA9564)
> > > + */
> > > +struct i2c_bus_settings {
> > > +   int mode;
> > > +   int tlow;
> > > +   int thi;
> > > +   int clock_freq;
> > > +};
> >
> > This is a good candidate to have it in generic header for sake of the
> > unification. Possible users:
> >
> > struct tegra_i2c_hw_feature
> > struct cci_data::struct hw_params
>
> Could be evaluated, but outside the scope of this patch, I think. This
> is a bugfix, so a self-contained patch makes backporting a lot easier.

True, my point here is to think if we were beneficial of this
definition in the i2c.h.

-- 
With Best Regards,
Andy Shevchenko