linux-kernel - Re: [PATCH 1/2] phy: marvell: comphy: Convert internal SMCC firmware return codes to errno

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200902170525.ksovu7ah3wbotkim@pali>
Date:   Wed, 2 Sep 2020 19:05:25 +0200
From:   Pali Rohár <pali@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Rob Herring <robh@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>,
        Marek Behún <marek.behun@....cz>,
        Tomasz Maciej Nowak <tmn505@...il.com>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/2] phy: marvell: comphy: Convert internal SMCC firmware
 return codes to errno

On Wednesday 02 September 2020 19:00:10 Andrew Lunn wrote:
> > > > +	switch (ret) {
> > > > +	case SMCCC_RET_SUCCESS:
> > > > +		return 0;
> > > > +	case SMCCC_RET_NOT_SUPPORTED:
> > > > +		return -EOPNOTSUPP;
> > > > +	default:
> > > > +		return -EINVAL;
> > > > +	}
> > > >  }
> > > 
> > > Hi Pali
> > > 
> > > Maybe this should be a global helper translating SMCCC_RET_* into a
> > > standard errno value?
> > > 
> > > 	 Andrew
> > 
> > Hello Andrew!
> > 
> > Well, I'm not sure if some standard global helper is the correct way for
> > marvell comphy handler. It returns 0 for success and -1 on error when
> > handler is not supported.
> 
> No, i was meaning just 
> 
> switch (ret) {
> case SMCCC_RET_SUCCESS:
> 	return 0;
> case SMCCC_RET_NOT_SUPPORTED:
> 	return -EOPNOTSUPP;
> default:
> 	return -EINVAL;
> }

But this is not a complete generic helper. There are more generic SMCC
return codes and generic helper should define and translate all of them.