linux-kernel - Re: [PATCH v7 2/5] perf/jevents: Add new structure to pass json fields.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34566244-88ba-562b-71cf-414a0ba307f4@huawei.com>
Date:   Wed, 2 Sep 2020 18:05:07 +0100
From:   John Garry <john.garry@...wei.com>
To:     Kajol Jain <kjain@...ux.ibm.com>, <acme@...nel.org>
CC:     <peterz@...radead.org>, <mingo@...hat.com>, <mark.rutland@....com>,
        <alexander.shishkin@...ux.intel.com>, <pc@...ibm.com>,
        <jolsa@...hat.com>, <namhyung@...nel.org>, <ak@...ux.intel.com>,
        <yao.jin@...ux.intel.com>, <linux-kernel@...r.kernel.org>,
        <linux-perf-users@...r.kernel.org>, <irogers@...gle.com>,
        <maddy@...ux.ibm.com>, <ravi.bangoria@...ux.ibm.com>
Subject: Re: [PATCH v7 2/5] perf/jevents: Add new structure to pass json
 fields.

On 02/09/2020 17:04, Kajol Jain wrote:
> This patch adds new structure called 'json_event' inside jevents.h
> file to improve the callback prototype inside jevent files.
> Initially, whenever user want to add new field, they need to update
> in all function callback which make it more and more complex with
> increased number of parmeters.
> With this change, we just need to add it in new structure 'json_event'.
> 
> Signed-off-by: Kajol Jain <kjain@...ux.ibm.com>
> Reviewed-by: Andi Kleen <ak@...ux.intel.com>

Reviewed-by: John Garry <john.garry@...wei.com>

> +static int json_events

Adding 'static' should have really been in the previous patch ...