linux-kernel - Re: [PATCH v2 1/1] i2c: algo-pca: Reapply i2c bus settings after reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51972597-db12-e9f2-235c-f68c7fba0e1d@alliedtelesis.co.nz>
Date:   Wed, 2 Sep 2020 20:57:27 +0000
From:   Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Evan Nimmo <Evan.Nimmo@...iedtelesis.co.nz>
CC:     "wsa@...nel.org" <wsa@...nel.org>,
        "jarkko.nikula@...ux.intel.com" <jarkko.nikula@...ux.intel.com>,
        "jdelvare@...e.de" <jdelvare@...e.de>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/1] i2c: algo-pca: Reapply i2c bus settings after
 reset


On 2/09/20 8:45 pm, Andy Shevchenko wrote:
> On Wed, Sep 02, 2020 at 11:43:56AM +0300, Andy Shevchenko wrote:
>> On Wed, Sep 02, 2020 at 09:17:47AM +1200, Evan Nimmo wrote:
>>> If something goes wrong (such as the SCL being stuck low) then we need
>>> to reset the PCA chip. The issue with this is that on reset we lose all
>>> config settings and the chip ends up in a disabled state which results
>>> in a lock up/high cpu usage. We need to re-apply any configuration that
>> cpu -> CPU (I guess Wolfram can decide with this when applying)
>>
>>> had previously been set and re-enable the chip.
>> FWIW,
>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> And actually you forgot Chris' tag... But I dunno if the moving struct
> definition is something that Chris might not like.
>
Fine by me.

Reviewed-by: Chris Packham <chris.packham@...iedtelesis.co.nz>