linux-kernel - Re: [PATCH v2 1/1] i2c: algo-pca: Reapply i2c bus settings after reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200902084538.GY1891694@smile.fi.intel.com>
Date:   Wed, 2 Sep 2020 11:45:38 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Evan Nimmo <evan.nimmo@...iedtelesis.co.nz>
Cc:     wsa@...nel.org, jarkko.nikula@...ux.intel.com, jdelvare@...e.de,
        chris.packham@...iedtelesis.co.nz, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] i2c: algo-pca: Reapply i2c bus settings after
 reset

On Wed, Sep 02, 2020 at 11:43:56AM +0300, Andy Shevchenko wrote:
> On Wed, Sep 02, 2020 at 09:17:47AM +1200, Evan Nimmo wrote:
> > If something goes wrong (such as the SCL being stuck low) then we need
> > to reset the PCA chip. The issue with this is that on reset we lose all
> > config settings and the chip ends up in a disabled state which results
> > in a lock up/high cpu usage. We need to re-apply any configuration that
> 
> cpu -> CPU (I guess Wolfram can decide with this when applying)
> 
> > had previously been set and re-enable the chip.
> 
> FWIW,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

And actually you forgot Chris' tag... But I dunno if the moving struct
definition is something that Chris might not like.

-- 
With Best Regards,
Andy Shevchenko