linux-kernel - Re: [PATCH v2 10/11] lockdep: Only trace IRQ edges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <559ff09a-275b-21bf-15f1-daa0d02d1c76@roeck-us.net>
Date:   Wed, 2 Sep 2020 06:48:30 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     peterz@...radead.org
Cc:     linux-kernel@...r.kernel.org, mingo@...nel.org, will@...nel.org,
        npiggin@...il.com, elver@...gle.com, jgross@...e.com,
        paulmck@...nel.org, rostedt@...dmis.org, rjw@...ysocki.net,
        joel@...lfernandes.org, svens@...ux.ibm.com, tglx@...utronix.de,
        davem@...emloft.net
Subject: Re: [PATCH v2 10/11] lockdep: Only trace IRQ edges

On 9/2/20 2:12 AM, peterz@...radead.org wrote:
> On Wed, Sep 02, 2020 at 11:09:35AM +0200, peterz@...radead.org wrote:
>> On Tue, Sep 01, 2020 at 09:21:37PM -0700, Guenter Roeck wrote:
>>> [    0.000000] WARNING: CPU: 0 PID: 0 at kernel/locking/lockdep.c:4875 check_flags.part.39+0x280/0x2a0
>>> [    0.000000] DEBUG_LOCKS_WARN_ON(lockdep_hardirqs_enabled())
>>
>>> [    0.000000] [<00000000004cff18>] lock_acquire+0x218/0x4e0
>>> [    0.000000] [<0000000000d740c8>] _raw_spin_lock+0x28/0x40
>>> [    0.000000] [<00000000009870f4>] p1275_cmd_direct+0x14/0x60
>>
>> Lol! yes, I can see that going side-ways... let me poke at that.
> 
> I suspect this will do.
> 
> diff --git a/arch/sparc/prom/p1275.c b/arch/sparc/prom/p1275.c
> index 889aa602f8d8..7cfe88e30b52 100644
> --- a/arch/sparc/prom/p1275.c
> +++ b/arch/sparc/prom/p1275.c
> @@ -38,7 +38,7 @@ void p1275_cmd_direct(unsigned long *args)
>  	unsigned long flags;
> 
>  	local_save_flags(flags);
> -	local_irq_restore((unsigned long)PIL_NMI);
> +	arch_local_irq_restore((unsigned long)PIL_NMI);
>  	raw_spin_lock(&prom_entry_lock);
> 
>  	prom_world(1);
> 
No, that doesn't help. Even removing that line entirely doesn't help.
The problem seems to be that interrupts are not enabled in the first
place. But why wasn't this a problem before ?

Guenter