linux-kernel - Re: [PATCH 01/10] USB: move snd_usb_pipe_sanity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h5z8v8isd.wl-tiwai@suse.de>
Date:   Thu, 03 Sep 2020 08:40:34 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Alan Stern <stern@...land.harvard.edu>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        himadrispandya@...il.com, dvyukov@...gle.com,
        linux-usb@...r.kernel.org, perex@...ex.cz, tiwai@...e.com,
        linux-kernel@...r.kernel.org, marcel@...tmann.org,
        johan.hedberg@...il.com, linux-bluetooth@...r.kernel.org,
        alsa-devel@...a-project.org,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Eli Billauer <eli.billauer@...il.com>,
        Emiliano Ingrassia <ingrassia@...genesys.com>,
        Alexander Tsoy <alexander@...y.me>,
        "Geoffrey D. Bennett" <g@...vu>, Jussi Laako <jussi@...arnerd.net>,
        Nick Kossifidis <mickflemm@...il.com>,
        Dmitry Panchenko <dmitry@...ystems.ee>,
        Chris Wulff <crwulff@...il.com>,
        Jesus Ramos <jesus-ramos@...e.com>
Subject: Re: [PATCH 01/10] USB: move snd_usb_pipe_sanity_check into the USB core

On Thu, 03 Sep 2020 02:45:53 +0200,
Alan Stern wrote:
> 
> In a few places here this check is completely unnecessary.  All it does 
> is verify that the device does have an endpoint 0 and the the type of 
> the endpoint matches the type of the pipe.  Well, every USB device 
> always has an endpoint 0, and it is always a bidirectional control 
> endpoint.  Therefore a simple static check is all you need: There's no 
> point calling usb_pipe_type_check() when the pipe is of the form 
> usb_{snd|rcv}ctrlpipe(dev, 0).
> 
> In short, this check should be removed completely; it does nothing.

Fair enough, but I think those removals should be in another patch.


thanks,

Takashi