[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20200903063800.27288-1-dawning.pang@gmail.com>
Date: Thu, 3 Sep 2020 14:38:00 +0800
From: Xiaoliang Pang <dawning.pang@...il.com>
To: herbert@...dor.apana.org.au, davem@...emloft.net,
matthias.bgg@...il.com, swboyd@...omium.org, yuehaibing@...wei.com,
tianjia.zhang@...ux.alibaba.com, ryder.lee@...iatek.com
Cc: linux-crypto@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
dawning.pang@...il.com
Subject: [PATCH] cypto: mediatek - fix leaks in mtk_desc_ring_alloc
In the init loop, if an error occurs in function 'dma_alloc_coherent',
then goto the err_cleanup section,
in the cleanup loop, after run i--,
the struct mtk_ring rising[i] will not be released,
causing a memory leak
Signed-off-by: Xiaoliang Pang <dawning.pang@...il.com>
---
drivers/crypto/mediatek/mtk-platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/mediatek/mtk-platform.c b/drivers/crypto/mediatek/mtk-platform.c
index 7e3ad085b5bd..05d341e4a696 100644
--- a/drivers/crypto/mediatek/mtk-platform.c
+++ b/drivers/crypto/mediatek/mtk-platform.c
@@ -469,7 +469,7 @@ static int mtk_desc_ring_alloc(struct mtk_cryp *cryp)
return 0;
err_cleanup:
- for (; i--; ) {
+ for (; i >= 0; --i) {
dma_free_coherent(cryp->dev, MTK_DESC_RING_SZ,
ring[i]->res_base, ring[i]->res_dma);
dma_free_coherent(cryp->dev, MTK_DESC_RING_SZ,
--
2.17.1
Powered by blists - more mailing lists