linux-kernel - Re: [PATCH] cypto: mediatek - fix leaks in mtk_desc_ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200904072154.GA24603@gondor.apana.org.au>
Date:   Fri, 4 Sep 2020 17:21:54 +1000
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Xiaoliang Pang <dawning.pang@...il.com>
Cc:     davem@...emloft.net, matthias.bgg@...il.com, swboyd@...omium.org,
        yuehaibing@...wei.com, tianjia.zhang@...ux.alibaba.com,
        ryder.lee@...iatek.com, linux-crypto@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        dawning.pang@...il.com
Subject: Re: [PATCH] cypto: mediatek - fix leaks in mtk_desc_ring_alloc

Xiaoliang Pang <dawning.pang@...il.com> wrote:
> In the init loop, if an error occurs in function 'dma_alloc_coherent',
> then goto the err_cleanup section,
> in the cleanup loop, after run i--, 
> the struct mtk_ring rising[i] will not be released,
> causing a memory leak
> 
> Signed-off-by: Xiaoliang Pang <dawning.pang@...il.com>
> ---
> drivers/crypto/mediatek/mtk-platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/mediatek/mtk-platform.c b/drivers/crypto/mediatek/mtk-platform.c
> index 7e3ad085b5bd..05d341e4a696 100644
> --- a/drivers/crypto/mediatek/mtk-platform.c
> +++ b/drivers/crypto/mediatek/mtk-platform.c
> @@ -469,7 +469,7 @@ static int mtk_desc_ring_alloc(struct mtk_cryp *cryp)
>        return 0;
> 
> err_cleanup:
> -       for (; i--; ) {
> +       for (; i >= 0; --i) {

How about a do while loop instead?

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt