linux-kernel - Re: [PATCH -next] perf bench: fix return value check in do_run_multi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 4 Sep 2020 13:22:08 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Yuehaibing <yuehaibing@...wei.com>
Cc:     peterz@...radead.org, mingo@...hat.com, mark.rutland@....com,
        alexander.shishkin@...ux.intel.com, jolsa@...hat.com,
        namhyung@...nel.org, irogers@...gle.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] perf bench: fix return value check in
 do_run_multi_threaded()

Em Fri, Sep 04, 2020 at 09:25:02PM +0800, Yuehaibing escreveu:
> On 2020/9/4 2:55, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Sep 03, 2020 at 03:54:51PM -0300, Arnaldo Carvalho de Melo escreveu:
> >>>> Fixes: 13edc237200c ("perf bench: Add a multi-threaded synthesize benchmark")
> >>>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

> >>> Thanks, applied, kudos for adding the Fixes: tag, appreciated!

> >> But...
 
> OOps, sorry for this, I'll pay attention next time.

Thanks!

- Arnaldo
 
> >>>> +++ b/tools/perf/bench/synthesize.c
> >>>> @@ -162,8 +162,8 @@ static int do_run_multi_threaded(struct target *target,
> >>>>  	init_stats(&event_stats);
> >>>>  	for (i = 0; i < multi_iterations; i++) {
> >>>>  		session = perf_session__new(NULL, false, NULL);
> >>>> -		if (!session)
> >>>> -			return -ENOMEM;
> >>>> +		if (IS_ERR(session)) {
> >>>> +			return PTR_ERR(session);

> >> This doesn't compile, so I take back that kudo ;-\

> >> I'm fixing this by removing that needless '{'.