linux-kernel - Re: [PATCH -next] perf bench: fix return value check in do_run_multi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6815e565-c3a2-c7a2-f164-8d3c56f9c516@huawei.com>
Date:   Fri, 4 Sep 2020 21:25:02 +0800
From:   Yuehaibing <yuehaibing@...wei.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
CC:     <peterz@...radead.org>, <mingo@...hat.com>, <mark.rutland@....com>,
        <alexander.shishkin@...ux.intel.com>, <jolsa@...hat.com>,
        <namhyung@...nel.org>, <irogers@...gle.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] perf bench: fix return value check in
 do_run_multi_threaded()


On 2020/9/4 2:55, Arnaldo Carvalho de Melo wrote:
> Em Thu, Sep 03, 2020 at 03:54:51PM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Thu, Sep 03, 2020 at 03:53:01PM -0300, Arnaldo Carvalho de Melo escreveu:
>>> Em Wed, Sep 02, 2020 at 10:05:26PM +0800, YueHaibing escreveu:
>>>> In case of error, the function perf_session__new() returns ERR_PTR()
>>>> and never returns NULL. The NULL test in the return value check
>>>> should be replaced with IS_ERR()
>>>>
>>>> Fixes: 13edc237200c ("perf bench: Add a multi-threaded synthesize benchmark")
>>>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>>>
>>> Thanks, applied, kudos for adding the Fixes: tag, appreciated!
>>
>> But...

OOps, sorry for this, I'll pay attention next time.

>>  
>>>> ---
>>>>  tools/perf/bench/synthesize.c | 4 ++--
>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/tools/perf/bench/synthesize.c b/tools/perf/bench/synthesize.c
>>>> index 8d624aea1c5e..e39daa609db2 100644
>>>> --- a/tools/perf/bench/synthesize.c
>>>> +++ b/tools/perf/bench/synthesize.c
>>>> @@ -162,8 +162,8 @@ static int do_run_multi_threaded(struct target *target,
>>>>  	init_stats(&event_stats);
>>>>  	for (i = 0; i < multi_iterations; i++) {
>>>>  		session = perf_session__new(NULL, false, NULL);
>>>> -		if (!session)
>>>> -			return -ENOMEM;
>>>> +		if (IS_ERR(session)) {
>>>> +			return PTR_ERR(session);
>>
>> This doesn't compile, so I take back that kudo ;-\
>>
>> I'm fixing this by removing that needless '{'.
> 
> diff --git a/tools/perf/bench/synthesize.c b/tools/perf/bench/synthesize.c
> index e39daa609db2ed9b..b2924e3181dc3844 100644
> --- a/tools/perf/bench/synthesize.c
> +++ b/tools/perf/bench/synthesize.c
> @@ -162,7 +162,7 @@ static int do_run_multi_threaded(struct target *target,
>  	init_stats(&event_stats);
>  	for (i = 0; i < multi_iterations; i++) {
>  		session = perf_session__new(NULL, false, NULL);
> -		if (IS_ERR(session)) {
> +		if (IS_ERR(session))
>  			return PTR_ERR(session);
>  
>  		atomic_set(&event_count, 0);
> 
> .
>