linux-kernel - Re: [PATCH] perf metric: Fix some memory leaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Sep 2020 13:28:31 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Ian Rogers <irogers@...gle.com>, Jiri Olsa <jolsa@...hat.com>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Stephane Eranian <eranian@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Andi Kleen <andi@...stfloor.org>,
        Kajol Jain <kjain@...ux.ibm.com>,
        John Garry <john.garry@...wei.com>
Subject: Re: [PATCH] perf metric: Fix some memory leaks

Em Fri, Sep 04, 2020 at 10:39:50PM +0900, Namhyung Kim escreveu:
> On Fri, Sep 4, 2020 at 1:02 PM Ian Rogers <irogers@...gle.com> wrote:
> >
> > On Thu, Sep 3, 2020 at 8:21 PM Namhyung Kim <namhyung@...nel.org> wrote:
> > >
> > > I found some memory leaks while reading the metric code.  Some are
> > > real and others only occur in the error path.
> >
> > Thanks Namhyung! Is it possible to get test coverage?
> > Ian
> 
> Not sure what you want..
> 
> As I found it from code inspection I don't know if there's a test covering this.
> 
> But as far as I can see, 2 of them are on the error path so maybe not easy
> to add a test, other one is called from perf list code, and the last one is on
> the normal code path so any test should cover it.

Humm, I assume all those fixes were for csets in a single Linux version,
right? Otherwise I think it'd be better to have a fix per Fixes tag, so
that they would go to the kernel sources where those bugs were fixed.

Thanks!

- Arnaldo