linux-kernel - Re: [PATCH v2] perf expr: Force encapsulation on expr_id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200904162920.GV3495158@kernel.org>
Date:   Fri, 4 Sep 2020 13:29:20 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Ian Rogers <irogers@...gle.com>
Cc:     kajoljain <kjain@...ux.ibm.com>, Jiri Olsa <jolsa@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Andi Kleen <ak@...ux.intel.com>,
        Jin Yao <yao.jin@...ux.intel.com>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Leo Yan <leo.yan@...aro.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH v2] perf expr: Force encapsulation on expr_id_data

Em Thu, Sep 03, 2020 at 10:53:16PM -0700, Ian Rogers escreveu:
> On Thu, Aug 27, 2020 at 12:00 AM kajoljain <kjain@...ux.ibm.com> wrote:
> >
> >
> >
> > On 8/26/20 9:27 PM, Jiri Olsa wrote:
> > > On Wed, Aug 26, 2020 at 08:30:55AM -0700, Ian Rogers wrote:
> > >> This patch resolves some undefined behavior where variables in
> > >> expr_id_data were accessed (for debugging) without being defined. To
> > >> better enforce the tagged union behavior, the struct is moved into
> > >> expr.c and accessors provided. Tag values (kinds) are explicitly
> > >> identified.
> >
> > Reviewed-By: Kajol Jain<kjain@...ux.ibm.com>
> >
> > Thanks,
> > Kajol Jain
> > >>
> > >> Signed-off-by: Ian Rogers <irogers@...gle.com>
> > >
> > > great, thanks for doing this
> > >
> > > Acked-by: Jiri Olsa <jolsa@...hat.com>
> > >
> > > jirka
> > >
> 
> Thanks for the reviews! Arnaldo could this get merged? Thanks!

I'll get this and the other outstanding patches into perf/core soon as I
got urgent stuff already merged by Linus,

Thanks!

- Arnaldo