linux-kernel - Re: [PATCH v2 0/2] leds: pwm: Make automatic labels work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <107cc1b1-501c-4946-facf-a437c1dfbf7a@gmail.com>
Date:   Fri, 4 Sep 2020 23:19:50 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Alexander Dahl <ada@...rsis.com>, linux-leds@...r.kernel.org
Cc:     Alexander Dahl <post@...pocky.de>, devicetree@...r.kernel.org,
        Pavel Machek <pavel@....cz>, Dan Murphy <dmurphy@...com>,
        Rob Herring <robh+dt@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] leds: pwm: Make automatic labels work

Hi Alexander,

On 9/4/20 9:53 AM, Alexander Dahl wrote:
> Hi Jacek,
> 
> Am Dienstag, 1. September 2020, 23:08:09 CEST schrieb Jacek Anaszewski:
>> Hi Alexander,
>>
>> Thanks for the v2.
>>
>> On 8/31/20 11:02 PM, Alexander Dahl wrote:
>>> Hei hei,
>>>
>>> for leds-gpio you can use the properties 'function' and 'color' in the
>>> devicetree node and omit 'label', the label is constructed
>>> automatically.  This is a common feature supposed to be working for all
>>> LED drivers.  However it did not yet work for the 'leds-pwm' driver.
>>> This series fixes the driver and takes the opportunity to update the
>>> dt-bindings accordingly.
>>>
>>> v1: based on v5.9-rc2, backport on v5.4.59 tested and working
>>>
>>> v2: based on v5.9-rc3, added the dt-bindings update patch
>>>
>>> Greets
>>> Alex
>>>
>>> Alexander Dahl (2):
>>>     leds: pwm: Allow automatic labels for DT based devices
>>>     dt-bindings: leds: Convert pwm to yaml
>>>    
>>>    .../devicetree/bindings/leds/leds-pwm.txt     | 50 -----------
>>>    .../devicetree/bindings/leds/leds-pwm.yaml    | 85 +++++++++++++++++++
>>>    drivers/leds/leds-pwm.c                       |  9 +-
>>>    3 files changed, 93 insertions(+), 51 deletions(-)
>>>    delete mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.txt
>>>    create mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.yaml
>>
>> For both patches:
>>
>> Acked-by: Jacek Anaszewski <jacek.anaszewski@...il.com>
> 
> I'd like to make a v3 and change the license of the .yaml file to "(GPL-2.0-
> only OR BSD-2-Clause)" as suggested by checkpatch and [1].  Can I keep your
> Acked-by for that?

Go ahead.

> Besides: those suggestions are obviously valid for new bindings.  What about
> old bindings (.txt), which had no explicit SPDX tag or license note before?
> What license would apply there?  Is the .yaml file technically new, when it
> was mostly just converted from .txt?

I don't know what was the rationale behind adding license to
DT bindings, probably Rob will be able to share some details.

Possibly the fact that DT examples can be now compile-tested
makes some difference here.

-- 
Best regards,
Jacek Anaszewski