linux-kernel - Re: [PATCH 3/3] crypto: s5p-sss - Pass error from clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Sep 2020 11:06:28 +0200
From:   Kamil Konieczny <k.konieczny@...sung.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        Vladimir Zapolskiy <vz@...ia.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>, linux-crypto@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] crypto: s5p-sss - Pass error from clk_get and
 reduce verbosity on deferral



On 9/3/20 8:04 PM, Krzysztof Kozlowski wrote:
> Pass the error directly from devm_clk_get() to describe the real reason,
> instead of fixed ENOENT.  Do not print error messages on deferred probe.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>  drivers/crypto/s5p-sss.c | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
> index f67f1e22ecd1..e83145c43b18 100644
> --- a/drivers/crypto/s5p-sss.c
> +++ b/drivers/crypto/s5p-sss.c
> @@ -2201,11 +2201,10 @@ static int s5p_aes_probe(struct platform_device *pdev)
>  	}
>  
>  	pdata->clk = devm_clk_get(dev, variant->clk_names[0]);
> -	if (IS_ERR(pdata->clk)) {
> -		dev_err(dev, "failed to find secss clock %s\n",
> -			variant->clk_names[0]);
> -		return -ENOENT;
> -	}
> +	if (IS_ERR(pdata->clk))
> +		return dev_err_probe(dev, PTR_ERR(pdata->clk),
> +				     "failed to find secss clock %s\n",
> +				     variant->clk_names[0]);
>  
>  	err = clk_prepare_enable(pdata->clk);
>  	if (err < 0) {
> @@ -2217,9 +2216,9 @@ static int s5p_aes_probe(struct platform_device *pdev)
>  	if (variant->clk_names[1]) {
>  		pdata->pclk = devm_clk_get(dev, variant->clk_names[1]);
>  		if (IS_ERR(pdata->pclk)) {
> -			dev_err(dev, "failed to find clock %s\n",
> -				variant->clk_names[1]);
> -			err = -ENOENT;
> +			err = dev_err_probe(dev, PTR_ERR(pdata->pclk),
> +					    "failed to find clock %s\n",
> +					    variant->clk_names[1]);
>  			goto err_clk;
>  		}
>  
> 

Reviewed-by: Kamil Konieczny <k.konieczny@...sung.com>
Acked-by: Kamil Konieczny <k.konieczny@...sung.com>