linux-kernel - Re: [PATCH 2/3] crypto: s5p-sss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad460c31-aa10-21a8-2fd9-698d5a7ca823@samsung.com>
Date:   Fri, 4 Sep 2020 11:07:05 +0200
From:   Kamil Konieczny <k.konieczny@...sung.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        Vladimir Zapolskiy <vz@...ia.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>, linux-crypto@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] crypto: s5p-sss - Add and fix kerneldoc



On 9/3/20 8:03 PM, Krzysztof Kozlowski wrote:
> Add missing and fix existing kerneldoc to silence W=1 warnings:
> 
>   drivers/crypto/s5p-sss.c:333: warning: Function parameter or member 'pclk' not described in 's5p_aes_dev'
>   drivers/crypto/s5p-sss.c:373: warning: Function parameter or member 'sgl' not described in 's5p_hash_reqctx'
>   drivers/crypto/s5p-sss.c:373: warning: Function parameter or member 'buffer' not described in 's5p_hash_reqctx'
>   drivers/crypto/s5p-sss.c:1143: warning: Function parameter or member 'new_len' not described in 's5p_hash_prepare_sgs'
>   drivers/crypto/s5p-sss.c:1143: warning: Excess function parameter 'nbytes' description in 's5p_hash_prepare_sgs'
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>  drivers/crypto/s5p-sss.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
> index 341433fbcc4a..f67f1e22ecd1 100644
> --- a/drivers/crypto/s5p-sss.c
> +++ b/drivers/crypto/s5p-sss.c
> @@ -260,6 +260,7 @@ struct s5p_aes_ctx {
>   * struct s5p_aes_dev - Crypto device state container
>   * @dev:	Associated device
>   * @clk:	Clock for accessing hardware
> + * @pclk:	APB bus clock necessary to access the hardware
>   * @ioaddr:	Mapped IO memory region
>   * @aes_ioaddr:	Per-varian offset for AES block IO memory
>   * @irq_fc:	Feed control interrupt line
> @@ -342,13 +343,13 @@ struct s5p_aes_dev {
>   * @engine:	Bits for selecting type of HASH in SSS block
>   * @sg:		sg for DMA transfer
>   * @sg_len:	Length of sg for DMA transfer
> - * @sgl[]:	sg for joining buffer and req->src scatterlist
> + * @sgl:	sg for joining buffer and req->src scatterlist
>   * @skip:	Skip offset in req->src for current op
>   * @total:	Total number of bytes for current request
>   * @finup:	Keep state for finup or final.
>   * @error:	Keep track of error.
>   * @bufcnt:	Number of bytes holded in buffer[]
> - * @buffer[]:	For byte(s) from end of req->src in UPDATE op
> + * @buffer:	For byte(s) from end of req->src in UPDATE op
>   */
>  struct s5p_hash_reqctx {
>  	struct s5p_aes_dev	*dd;
> @@ -1125,7 +1126,7 @@ static int s5p_hash_copy_sg_lists(struct s5p_hash_reqctx *ctx,
>   * s5p_hash_prepare_sgs() - prepare sg for processing
>   * @ctx:	request context
>   * @sg:		source scatterlist request
> - * @nbytes:	number of bytes to process from sg
> + * @new_len:	number of bytes to process from sg
>   * @final:	final flag
>   *
>   * Check two conditions: (1) if buffers in sg have len aligned data, and (2)
> 

Reviewed-by: Kamil Konieczny <k.konieczny@...sung.com>
Acked-by: Kamil Konieczny <k.konieczny@...sung.com>