linux-kernel - Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200907174705.clknw4375smvt47o@pali>
Date:   Mon, 7 Sep 2020 19:47:05 +0200
From:   Pali Rohár <pali@...nel.org>
To:     Andre Heider <a.heider@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>, Jason Cooper <jason@...edaemon.net>,
        Gregory Clement <gregory.clement@...tlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Tomasz Maciej Nowak <tmn505@...il.com>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch
 aliases

On Monday 07 September 2020 19:43:08 Andre Heider wrote:
> On 07/09/2020 19:35, Pali Rohár wrote:
> > On Monday 07 September 2020 19:23:03 Andrew Lunn wrote:
> > > > My dts-foo is a little rusty, but now that you labeled the ports in the
> > > > .dtsi, can this whole "switch0" block reduced to something like:
> > > > 
> > > > &switch0port1 {
> > > > 	label = "lan1";
> > > > };
> > > > 
> > > > &switch0port3 {
> > > > 	label = "wan";
> > > > };
> > > 
> > > Probably yes.
> > > 
> > > But that is definitely too much for stable.
> > 
> > Yes, this suggested change is not for stable, but looks like a nice
> > cleanup. So it could be done in followup patch.
> > 
> > Andre, are you going to prepare and test this followup change?
> 
> I can prep the patch if you like, but the suggested cleanup only affects the
> v7 dts files. I don't have that hardware version to test it, so could only
> send an untested patch.

As a result of this cleanup should be binary DTB file for V7 with same
structure as DTB file without such cleanup patch, right? And this test
(structure / content of compiled file) does not need particular hardware.