linux-kernel - Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c0e3c31-866d-d53a-5a5c-d66e2da27f6c@gmail.com>
Date:   Mon, 7 Sep 2020 19:44:19 +0200
From:   Andre Heider <a.heider@...il.com>
To:     Pali Rohár <pali@...nel.org>
Cc:     Jason Cooper <jason@...edaemon.net>, Andrew Lunn <andrew@...n.ch>,
        Gregory Clement <gregory.clement@...tlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Tomasz Maciej Nowak <tmn505@...il.com>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch
 aliases

On 07/09/2020 19:42, Pali Rohár wrote:
> On Monday 07 September 2020 19:13:41 Andre Heider wrote:
>>> @@ -120,7 +124,7 @@
>>>    			#address-cells = <1>;
>>>    			#size-cells = <0>;
>>> -			port@0 {
>>> +			switch0port0: port@0 {
>>
>> This label is unused it seems.
> 
> Yes, it is unused, but I defined labels for all ports so it would be
> clean that ports are indexed from zero and not from one. Also it looks
> inconsistent if some of DSA ports have labels and some does not.

Alright, sounds good:
Reviewed-by: Andre Heider <a.heider@...il.com>

> 
>>
>>>    				reg = <0>;
>>>    				label = "cpu";
>>>    				ethernet = <&eth0>;
>>> @@ -131,19 +135,19 @@
>>>    				};
>>>    			};
>>> -			port@1 {
>>> +			switch0port1: port@1 {
>>>    				reg = <1>;
>>>    				label = "wan";
>>>    				phy-handle = <&switch0phy0>;
>>>    			};
>>> -			port@2 {
>>> +			switch0port2: port@2 {
>>>    				reg = <2>;
>>>    				label = "lan0";
>>>    				phy-handle = <&switch0phy1>;
>>>    			};
>>> -			port@3 {
>>> +			switch0port3: port@3 {
>>>    				reg = <3>;
>>>    				label = "lan1";
>>>    				phy-handle = <&switch0phy2>;
>>>
>>