linux-kernel - Re: [PATCH] mwifiex: sdio: Fix -Wunused-const-variable warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 7 Sep 2020 08:35:27 +0000
From:   Kalle Valo <kvalo@...eaurora.org>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     <amitkarwar@...il.com>, <ganapathi.bhat@....com>,
        <huxinming820@...il.com>, <davem@...emloft.net>, <kuba@...nel.org>,
        <yuehaibing@...wei.com>, <linux-wireless@...r.kernel.org>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mwifiex: sdio: Fix -Wunused-const-variable warnings

YueHaibing <yuehaibing@...wei.com> wrote:

> These variables only used in sdio.c, move them to .c file
> can silence these warnings:
> 
> In file included from drivers/net/wireless/marvell/mwifiex//main.h:59:0,
>                  from drivers/net/wireless/marvell/mwifiex//cfp.c:24:
> drivers/net/wireless/marvell/mwifiex//sdio.h:705:41: warning: ‘mwifiex_sdio_sd8801’ defined but not used [-Wunused-const-variable=]
>  static const struct mwifiex_sdio_device mwifiex_sdio_sd8801 = {
>                                          ^~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/marvell/mwifiex//sdio.h:689:41: warning: ‘mwifiex_sdio_sd8987’ defined but not used [-Wunused-const-variable=]
>  static const struct mwifiex_sdio_device mwifiex_sdio_sd8987 = {
>                                          ^~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/marvell/mwifiex//sdio.h:674:41: warning: ‘mwifiex_sdio_sd8887’ defined but not used [-Wunused-const-variable=]
>  static const struct mwifiex_sdio_device mwifiex_sdio_sd8887 = {
>                                          ^~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/marvell/mwifiex//sdio.h:658:41: warning: ‘mwifiex_sdio_sd8997’ defined but not used [-Wunused-const-variable=]
>  static const struct mwifiex_sdio_device mwifiex_sdio_sd8997 = {
>                                          ^~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/marvell/mwifiex//sdio.h:642:41: warning: ‘mwifiex_sdio_sd8977’ defined but not used [-Wunused-const-variable=]
>  static const struct mwifiex_sdio_device mwifiex_sdio_sd8977 = {
>                                          ^~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/marvell/mwifiex//sdio.h:627:41: warning: ‘mwifiex_sdio_sd8897’ defined but not used [-Wunused-const-variable=]
>  static const struct mwifiex_sdio_device mwifiex_sdio_sd8897 = {
>                                          ^~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/marvell/mwifiex//sdio.h:612:41: warning: ‘mwifiex_sdio_sd8797’ defined but not used [-Wunused-const-variable=]
>  static const struct mwifiex_sdio_device mwifiex_sdio_sd8797 = {
>                                          ^~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/marvell/mwifiex//sdio.h:597:41: warning: ‘mwifiex_sdio_sd8787’ defined but not used [-Wunused-const-variable=]
>  static const struct mwifiex_sdio_device mwifiex_sdio_sd8787 = {
>                                          ^~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/marvell/mwifiex//sdio.h:582:41: warning: ‘mwifiex_sdio_sd8786’ defined but not used [-Wunused-const-variable=]
>  static const struct mwifiex_sdio_device mwifiex_sdio_sd8786 = {
>                                          ^~~~~~~~~~~~~~~~~~~
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Patch applied to wireless-drivers-next.git, thanks.

992a23702554 mwifiex: sdio: Fix -Wunused-const-variable warnings

-- 
https://patchwork.kernel.org/patch/11750823/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches