linux-kernel - Re: [PATCH] ASoC: rt5682: Have global name clock option for parent clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200907110601.GC4907@sirena.org.uk>
Date:   Mon, 7 Sep 2020 12:06:01 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Akshu Agrawal <akshu.agrawal@....com>
Cc:     derek.fang@...ltek.com, Oder Chiou <oder_chiou@...ltek.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." 
        <alsa-devel@...a-project.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: rt5682: Have global name clock option for parent
 clk

On Mon, Sep 07, 2020 at 09:30:37AM +0530, Akshu Agrawal wrote:
> When adding parent clk(mclk) to wclk, this adds fallback option
> for the case where global clk name is used.

> @@ -2780,6 +2780,7 @@ static int rt5682_register_dai_clks(struct snd_soc_component *component)
>  			if (rt5682->mclk) {
>  				init.parent_data = &(struct clk_parent_data){
>  					.fw_name = "mclk",
> +					.name = __clk_get_name(rt5682->mclk),
>  				};
>  				init.num_parents = 1;
>  			}

I don't understand this change - we clearly already have the clock so
why can't we just use whatever we used when we originally looked it up
here?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)