linux-kernel - Re: [PATCH] PM: <linux/device.h>: fix @em

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6de9dd19-3bbc-41a7-b36d-9f085eb2e548@arm.com>
Date:   Mon, 7 Sep 2020 12:29:55 +0100
From:   Lukasz Luba <lukasz.luba@....com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux PM list <linux-pm@...r.kernel.org>,
        Rafael Wysocki <rafael.j.wysocki@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] PM: <linux/device.h>: fix @em_pd kernel-doc warning

Hi Randy,

On 9/7/20 4:42 AM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> Fix kernel-doc warning in <linux/device.h>:
> 
> ../include/linux/device.h:613: warning: Function parameter or member 'em_pd' not described in 'device'
> 
> Fixes: 1bc138c62295 ("PM / EM: add support for other devices than CPUs in Energy Model")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Lukasz Luba <lukasz.luba@....com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
>   include/linux/device.h |    1 +
>   1 file changed, 1 insertion(+)
> 
> --- lnx-59-rc4.orig/include/linux/device.h
> +++ lnx-59-rc4/include/linux/device.h
> @@ -454,6 +454,7 @@ struct dev_links_info {
>    * @pm_domain:	Provide callbacks that are executed during system suspend,
>    * 		hibernation, system resume and during runtime PM transitions
>    * 		along with subsystem-level and driver-level callbacks.
> + * @em_pd:	device's energy model performance domain
>    * @pins:	For device pin management.
>    *		See Documentation/driver-api/pinctl.rst for details.
>    * @msi_list:	Hosts MSI descriptors
> 

Good catch. Thank you for the patch.

Reviewed-by: Lukasz Luba <lukasz.luba@....com>

Regards,
Lukasz Luba