linux-kernel - Re: [PATCH 03/12] x86/platform/uv: Adjust references in UV kernel modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Sep 2020 17:22:07 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Mike Travis <mike.travis@....com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org, Steve Wahl <steve.wahl@....com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Andy Lutomirski <luto@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...e.de>,
        Dimitri Sivanich <dimitri.sivanich@....com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Russ Anderson <russ.anderson@....com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Alexandre Chartre <alexandre.chartre@...cle.com>,
        Jian Cai <caij2003@...il.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH 03/12] x86/platform/uv: Adjust references in UV kernel
 modules

On Mon, Sep 07, 2020 at 01:54:33PM -0500, Mike Travis wrote:
> There is a symbol clash from the auto-generated uv_mmrs.h file that
> clashes with code in the UV kernel modules (is_uv() is the symbol).
> Change those prior to the symbol clash so as to not cause a compile error.
> 
> Signed-off-by: Mike Travis <mike.travis@....com>
> Reviewed-by: Dimitri Sivanich <dimitri.sivanich@....com>
> Reviewed-by: Steve Wahl <steve.wahl@....com>
> ---
>  drivers/misc/sgi-xp/xp.h            |   11 ++++++-----
>  drivers/misc/sgi-xp/xp_main.c       |    7 ++++---
>  drivers/misc/sgi-xp/xp_uv.c         |    9 ++++++---
>  drivers/misc/sgi-xp/xpc_main.c      |    9 +++++----
>  drivers/misc/sgi-xp/xpc_partition.c |    5 +++--
>  drivers/misc/sgi-xp/xpnet.c         |    5 +++--
>  6 files changed, 27 insertions(+), 19 deletions(-)
> 
> --- linux.orig/drivers/misc/sgi-xp/xp.h
> +++ linux/drivers/misc/sgi-xp/xp.h
> @@ -3,7 +3,8 @@
>   * License.  See the file "COPYING" in the main directory of this archive
>   * for more details.
>   *
> - * Copyright (C) 2004-2008 Silicon Graphics, Inc. All rights reserved.
> + * Copyright (c) 2018-2020 Hewlett Packard Enterprise Development LP
> + * Copyright (c) 2008-2017 Silicon Graphics, Inc.  All Rights Reserved.

This change does not make sense.  If you want to make it, please make it
in a separate patch that justifies the dates being added here please.

thanks,

greg k-h