linux-kernel - Re: [PATCH v3] mmc: host: Enable compile testing of multiple drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Sep 2020 15:56:51 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v3] mmc: host: Enable compile testing of multiple drivers

On Tue, 8 Sep 2020 at 15:54, Ulf Hansson <ulf.hansson@...aro.org> wrote:
>
> + Arnd
>
> On Mon, 7 Sep 2020 at 12:53, Krzysztof Kozlowski <krzk@...nel.org> wrote:
> >
> > Multiple MMC host controller driver can be compile tested as they do not
> > depend on architecture specific headers.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
>
> It seems like this is causing build errors for my next branch when
> running allmod config [1].
>
> [...]
>
> >
> >  config MMC_S3C
> >         tristate "Samsung S3C SD/MMC Card Interface support"
> > -       depends on ARCH_S3C24XX
> > +       depends on ARCH_S3C24XX || COMPILE_TEST
> >         depends on S3C24XX_DMAC
> >         help
> >           This selects a driver for the MCI interface found in
>
> [...]
>
> The problem doesn't exist in linux-next, since it has the
> corresponding cleanup/rework patches for MMC_S3C from Arnd.
>
> To fix the problem, we should probably remove COMPILE_TEST for
> MMC_S3C, for now. Then we can add it again and send it as a fix for
> v5.10-rc1.
>
> What do you think?

Yes, better to remove it otherwise it will pop up when Linus merges
your tree. Do you want a patch for this or you fix it up by yourself?

Best regards,
Krzysztof