linux-kernel - Re: [PATCH v2 10/11] dwc3-of-simple: add support for Hikey 970

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sgbslnjs.fsf@kernel.org>
Date:   Tue, 08 Sep 2020 10:45:11 +0300
From:   Felipe Balbi <balbi@...nel.org>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc:     linuxarm@...wei.com, mauro.chehab@...wei.com,
        John Stultz <john.stultz@...aro.org>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 10/11] dwc3-of-simple: add support for Hikey 970

Mauro Carvalho Chehab <mchehab+huawei@...nel.org> writes:

> Em Mon,  7 Sep 2020 17:59:34 +0200
> Mauro Carvalho Chehab <mchehab+huawei@...nel.org> escreveu:
>
>> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
>> index 8852fbfdead4..2d497165efe2 100644
>> --- a/drivers/usb/dwc3/dwc3-of-simple.c
>> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
>> @@ -49,7 +49,8 @@ static int dwc3_of_simple_probe(struct platform_device *pdev)
>>  	 * Some controllers need to toggle the usb3-otg reset before trying to
>>  	 * initialize the PHY, otherwise the PHY times out.
>>  	 */
>> -	if (of_device_is_compatible(np, "rockchip,rk3399-dwc3"))
>> +	if (of_device_is_compatible(np, "rockchip,rk3399-dwc3") ||
>> +	    of_device_is_compatible(np, "hisilicon,hi3670-dwc3"))
>>  		simple->need_reset = true;
>
> It turns that this hunk caused Serror during my suspend/resume tests.
>
> Without this one, the driver works just fine.
>
> As you already applied this patch, do you prefer a patch dropping it,
> or should I send a version 2 without it?

Send me a new one, I'll remove the patch.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (858 bytes)