linux-kernel - Re: [PATCH v3 3/5] ASoC: qcom: Add support for lpass hdmi driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <010101746ed032f5-3967f10b-7d55-40ab-a674-63f1ff370565-000000@us-west-2.amazonses.com>
Date:   Tue, 8 Sep 2020 17:42:52 +0000
From:   Srinivasa Rao Mandadapu <srivasam@...eaurora.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        agross@...nel.org, bjorn.andersson@...aro.org, lgirdwood@...il.com,
        broonie@...nel.org, robh+dt@...nel.org, plai@...eaurora.org,
        bgoswami@...eaurora.org, perex@...ex.cz, tiwai@...e.com,
        rohitkr@...eaurora.org, linux-arm-msm@...r.kernel.org,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     V Sujith Kumar Reddy <vsujithk@...eaurora.org>
Subject: Re: [PATCH v3 3/5] ASoC: qcom: Add support for lpass hdmi driver

Thanks for your reply Srinivas!!!

On 9/4/2020 4:54 PM, Srinivas Kandagatla wrote:
>
>
> On 04/09/2020 12:21, Srinivasa Rao Mandadapu wrote:
>>>
>>> Before going into detail review, I see real issue in the overall 
>>> approach here to add new interface to exiting lpass!!
>>>
>>> Intention of struct lpass_variant is to address differences between 
>>> SoCs or different lpass versions. But you should not duplicate this 
>>> and use it for addressing differences between each lpass interfaces!
>>> All the dai related register offsets should still go in to this 
>>> structure and driver should be able to know which dai its talking to 
>>> based on snd_soc_dai_driver id and select correct register offset.
>>>
>> Do You suggest to use separate structure like struct 
>> lpass_hdmi_interface in lpass_data?
>
> No, you should just put every thing lpass_variant as you did but no 
> "id" thing in that.
Okay. will change accordingly.
>
> --srini

-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.