[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 9 Sep 2020 14:22:51 -0600
From: Rob Herring <robh@...nel.org>
To: Arnaud Pouliquen <arnaud.pouliquen@...com>
Cc: Alexandre Torgue <alexandre.torgue@...com>,
devicetree@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org,
linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org,
Fabien Dessenne <fabien.dessenne@...com>,
Mathieu Poirier <mathieu.poirier@...aro.org>,
Ohad Ben-Cohen <ohad@...ery.com>,
Bjorn Andersson <bjorn.andersson@...aro.org>
Subject: Re: [PATCH 2/3] dt-bindings: remoteproc: stm32_rproc: update for
firmware synchronization
On Thu, Aug 27, 2020 at 09:21:00AM +0200, Arnaud Pouliquen wrote:
> Add new properties description used to attach to a pre-loaded
> firmware according to the commit 9276536f455b3
> ("remoteproc: stm32: Parse syscon that will manage M4 synchronisation")
> which updates the driver part.
>
> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@...com>
> ---
> .../bindings/remoteproc/st,stm32-rproc.yaml | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
> index 4ffa25268fcc..e50957d86b1c 100644
> --- a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
> @@ -96,6 +96,25 @@ properties:
> 3rd cell: register bitmask for the deep sleep bit
> maxItems: 1
>
> + st,syscfg-m4-state:
> + $ref: "/schemas/types.yaml#/definitions/phandle-array"
> + description: |
> + Reference to the tamp register which exposes the Cortex-M4 state.
> + 1st cell: phandle to syscon block
> + 2nd cell: register offset containing the Cortex-M4 state
> + 3rd cell: register bitmask for the Cortex-M4 state
> + maxItems: 1
> +
> + st,syscfg-rsc-tbl:
> + $ref: "/schemas/types.yaml#/definitions/phandle-array"
> + description: |
> + Reference to the tamp register which references the Cortex-M4
> + resource table address.
> + 1st cell: phandle to syscon block
> + 2nd cell: register offset containing the resource table address
> + 3rd cell: register bitmask for the resource table address
> + maxItems: 1
Why can't these be implied? You can lookup the tamp syscon by
compatible.
Please add these to the example.
> +
> st,auto-boot:
> $ref: /schemas/types.yaml#/definitions/flag
> description:
> --
> 2.17.1
>
Powered by blists - more mailing lists